feat(wasm-utxo): add PSBT fromNetworkFormat#264
Merged
OttoAllmendinger merged 1 commit intomasterfrom Apr 24, 2026
Merged
Conversation
36f37e6 to
ab2ad4e
Compare
Deprecate fromHalfSignedLegacyTransaction in favor of fromNetworkFormat, which accepts unsigned, half-signed, and fully-signed transactions. Signature-count enforcement moves to callers. The new API parses fixed-script inputs (multisig or replay protection) and applies signatures using either positional slot indices (if any OP_0 placeholders exist) or ECDSA verification against wallet pubkeys (if all slots are compact). This enables hydration of finalized transactions that were previously rejected by the legacy parser. For Zcash, use ZcashBitGoPsbt.fromNetworkFormat with block height or explicit consensus branch ID. All legacy variants delegate to the new implementation internally for backward compatibility. Issue: BTC-0 Co-authored-by: llm-git <llm-git@ttll.de>
ab2ad4e to
9405b00
Compare
lcovar
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate fromHalfSignedLegacyTransaction in favor of fromNetworkFormat,
which accepts unsigned, half-signed, and fully-signed transactions.
Signature-count enforcement moves to callers.
The new API parses fixed-script inputs (multisig or replay protection)
and applies signatures using either positional slot indices (if any
OP_0 placeholders exist) or ECDSA verification against wallet pubkeys
(if all slots are compact). This enables hydration of finalized
transactions that were previously rejected by the legacy parser.
For Zcash, use ZcashBitGoPsbt.fromNetworkFormat with block height or
explicit consensus branch ID. All legacy variants delegate to the new
implementation internally for backward compatibility.
Issue: BTC-0
Co-authored-by: llm-git llm-git@ttll.de